]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/mlx5: Drop redundant work canceling from clean_keys()
authorMichael Guralnik <michaelgur@nvidia.com>
Tue, 3 Sep 2024 11:24:47 +0000 (14:24 +0300)
committerLeon Romanovsky <leon@kernel.org>
Mon, 9 Sep 2024 18:17:09 +0000 (21:17 +0300)
The canceling of dealyed work in clean_keys() is a leftover from years
back and was added to prevent races in the cleanup process of MR cache.
The cleanup process was rewritten a few years ago and the canceling of
delayed work and flushing of workqueue was added before the call to
clean_keys().

Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
Link: https://patch.msgid.link/943d21f5a9dba7b98a3e1d531e3561ffe9745d71.1725362530.git.leon@kernel.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mlx5/mr.c

index 250c246ae7921ab017db2e440c4ad473fe194fb8..511d5049135226bfede877e05d5a8ee4942b9511 100644 (file)
@@ -772,7 +772,6 @@ static void clean_keys(struct mlx5_ib_dev *dev, struct mlx5_cache_ent *ent)
 {
        u32 mkey;
 
-       cancel_delayed_work(&ent->dwork);
        spin_lock_irq(&ent->mkeys_queue.lock);
        while (ent->mkeys_queue.ci) {
                mkey = pop_mkey_locked(ent);