]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virGDBusBusInit: Properly check for error when looking up D-Bus address
authorMichal Privoznik <mprivozn@redhat.com>
Fri, 6 Nov 2020 12:47:19 +0000 (13:47 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 6 Nov 2020 15:52:11 +0000 (16:52 +0100)
The virGDBusBusInit is supposed to return a reference to
requested bus type (system/session) or, if non-shared bus is
requested then create a new bus of the type. As an argument, it
gets a double pointer to GError which is passed to all g_dbus_*()
calls which allocate it on failure. Pretty standard approach.
However, since it is a double pointer we must dereference the
first level to see if the value is NULL. IOW:

  if (*error)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/util/virgdbus.c

index 4360a6acff965926d4c68b6d4843c523940048cb..19fd7e2fe486f348efbf900aced52ad729da5619 100644 (file)
@@ -55,7 +55,7 @@ virGDBusBusInit(GBusType type, GError **error)
         return g_bus_get_sync(type, NULL, error);
     } else {
         address = g_dbus_address_get_for_bus_sync(type, NULL, error);
-        if (error)
+        if (*error)
             return NULL;
         return g_dbus_connection_new_for_address_sync(address,
                                                       G_DBUS_CONNECTION_FLAGS_NONE,