]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
nptl: initialize cpu_id_start prior to rseq registration
authorMichael Jeanson <mjeanson@efficios.com>
Wed, 20 Nov 2024 19:15:42 +0000 (14:15 -0500)
committerMichael Jeanson <mjeanson@efficios.com>
Fri, 6 Dec 2024 16:08:55 +0000 (16:08 +0000)
When adding explicit initialization of rseq fields prior to
registration, I glossed over the fact that 'cpu_id_start' is also
documented as initialized by user-space.

While current kernels don't validate the content of this field on
registration, future ones could.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
(cherry picked from commit d9f40387d3305d97e30a8cf8724218c42a63680a)

sysdeps/unix/sysv/linux/rseq-internal.h

index 538160b617f79bd58daea8a749a51cf39260bb9f..1aa63eca67504e2c66d459ffd61ead5bb2d31ba1 100644 (file)
@@ -56,6 +56,7 @@ rseq_register_current_thread (struct pthread *self, bool do_rseq)
          registration, there is no guarantee that struct pthread is
          cleared on all architectures.  */
       THREAD_SETMEM (self, rseq_area.cpu_id, RSEQ_CPU_ID_UNINITIALIZED);
+      THREAD_SETMEM (self, rseq_area.cpu_id_start, 0);
       THREAD_SETMEM (self, rseq_area.rseq_cs, 0);
       THREAD_SETMEM (self, rseq_area.flags, 0);