]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
ssl : SSLProbingParser overflow fix
authorPhilippe Antoine <contact@catenacyber.fr>
Wed, 27 Mar 2019 21:56:15 +0000 (22:56 +0100)
committerVictor Julien <victor@inliniac.net>
Tue, 30 Apr 2019 09:12:28 +0000 (11:12 +0200)
Found by fuzzing
Fixes ssl detection evasion by packet splitting

src/app-layer-ssl.c

index d73658b64d22f96e80611f510344d98172c72467..96411cd268beb0a14bac72f8caa525d053580616 100644 (file)
@@ -2628,7 +2628,7 @@ static AppProto SSLProbingParser(Flow *f, uint8_t direction,
         uint8_t *input, uint32_t ilen, uint8_t *rdir)
 {
     /* probably a rst/fin sending an eof */
-    if (ilen == 0)
+    if (ilen < 3)
         return ALPROTO_UNKNOWN;
 
     /* for now just the 3 byte header ones */