]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: Fix wrong P2P device link id issue
authorYingying Tang <yingying.tang@oss.qualcomm.com>
Tue, 13 Jan 2026 05:46:36 +0000 (13:46 +0800)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Tue, 13 Jan 2026 15:25:02 +0000 (07:25 -0800)
Wrong P2P device link id value of 0 was introduced in ath12k_mac_op_tx() by [1].

During the P2P negotiation process, there is only one scan vdev with link ID 15.
Currently, the device link ID is incorrectly set to 0 in ath12k_mac_op_tx()
during the P2P negotiation process, which leads to TX failures.

Set the correct P2P device link ID to 15 to fix the TX failure issue.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3

Fixes: 648a121bafa3 ("wifi: ath12k: ath12k_mac_op_tx(): MLO support") # [1]
Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Cc: linux-next@vger.kernel.org
Cc: netdev@vger.kernel.org
Link: https://patch.msgid.link/20260113054636.2620035-1-yingying.tang@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---

Note to linux-next and netdev maintainers:

This patch going through the "current" tree conflicts with
the following going through the "next" tree:
commit 631ee338f04d ("Merge branch 'ath12k-ng' into ath-next")

The conflict resolution is to leave the following file unmodified:
drivers/net/wireless/ath/ath12k/mac.

And to apply the following patch to ath12k_wifi7_mac_op_tx()
in the file drivers/net/wireless/ath/ath12k/wifi7/hw.c -705,7 +705,10

  return;
  }
  } else {
- link_id = 0;
+ if (vif->type == NL80211_IFTYPE_P2P_DEVICE)
+ link_id = ATH12K_FIRST_SCAN_LINK;
+ else
+ link_id = 0;
  }

  arvif = rcu_dereference(ahvif->link[link_id]);

drivers/net/wireless/ath/ath12k/mac.c

index 8476a1ff308dbd540dfbb04c6e684470e2713b99..e0e49f782bf8dfeef1616ab319e8005981eecd48 100644 (file)
@@ -9173,7 +9173,10 @@ static void ath12k_mac_op_tx(struct ieee80211_hw *hw,
                        return;
                }
        } else {
-               link_id = 0;
+               if (vif->type == NL80211_IFTYPE_P2P_DEVICE)
+                       link_id = ATH12K_FIRST_SCAN_LINK;
+               else
+                       link_id = 0;
        }
 
        arvif = rcu_dereference(ahvif->link[link_id]);