]> git.ipfire.org Git - thirdparty/ulogd2.git/commitdiff
ulogd: close logfile description in the exit path of parent process
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 26 Mar 2013 21:48:58 +0000 (22:48 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 26 Mar 2013 21:54:48 +0000 (22:54 +0100)
Joan Touzet reported that file descriptor 3 was not ever closed
in the exit path of the parent process:

open("ulogd.conf", O_RDONLY)            = 3

That corresponds to the the file descriptor that was used to
parse the configuration file was not closed.

This closes: http://bugzilla.netfilter.org/show_bug.cgi?id=793

Reported-by: Joan Touzet <joant@cloudant.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/ulogd.c

index b28d0f858dd66676db901a7ed3cc7412500955cf..ded9218f2367950ab9a4f19cf0bc5ddb24578464 100644 (file)
@@ -1277,6 +1277,7 @@ int main(int argc, char* argv[])
                        fclose(stdout);
                fclose(stderr);
                fclose(stdin);
+               fclose(logfile);
                setsid();
        }