Fix resource leak in resolver (bug 19257)

The number of currently defined nameservers is stored in ->nscount,
whereas ->_u._ext.nscount is set by __libc_res_nsend only after local
initializations.

(cherry picked from commit 5e7fdabd7df1fc6c56d104e61390bf5a6b526c38)

diff --git a/ChangeLog b/ChangeLog
index 4abbd3b5dced2e8ac887ec3daeb2e4e66990fcd0..8f5b28f9441cfc0fa5cb1cf56a1f8fafbb8f52cd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-03-15  Andreas Schwab  <schwab@suse.de>
+
+       [BZ #19257]
+       * resolv/res_init.c (__res_iclose): Use statp->nscount instead of
+       statp->_u._ext.nscount as loop count.
+
 2016-03-11  H.J. Lu  <hongjiu.lu@intel.com>
 
        [BZ #19758]

diff --git a/resolv/res_init.c b/resolv/res_init.c
index e0b6a80dc7656c6a7565fd39d18aed74599a108c..6c951f526eff36eea4e449422845f3c5804a03ee 100644 (file)
--- a/resolv/res_init.c
+++ b/resolv/res_init.c
@@ -594,7 +594,7 @@ __res_iclose(res_state statp, bool free_addr) {
                statp->_vcsock = -1;
                statp->_flags &= ~(RES_F_VC | RES_F_CONN);
        }
-       for (ns = 0; ns < statp->_u._ext.nscount; ns++)
+       for (ns = 0; ns < statp->nscount; ns++)
                if (statp->_u._ext.nsaddrs[ns]) {
                        if (statp->_u._ext.nssocks[ns] != -1) {
                                close_not_cancel_no_status(statp->_u._ext.nssocks[ns]);