s3:utils - explicitly free cmdline_messaging_context

Some command line utilities do not free their messaging context
which results in extra entries being left in the msg.lock directory.

Signed-off-by: Andrew Walker <awalker@ixsystems.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan  5 21:30:08 UTC 2021 on sn-devel-184

diff --git a/source3/utils/mdfind.c b/source3/utils/mdfind.c
index ef2657e4fa56811ae52ab4282920547d60c3a117..cecbea4f107d98b17a57dc21f306cb48d98cffba 100644 (file)
--- a/source3/utils/mdfind.c
+++ b/source3/utils/mdfind.c
@@ -251,6 +251,7 @@ int main(int argc, char **argv)
                goto fail;
        }
 
+       cmdline_messaging_context_free();
        TALLOC_FREE(frame);
        poptFreeContext(pc);
        return 0;

diff --git a/source3/utils/net.c b/source3/utils/net.c
index e289b2814bce2fa6725d5080a656c3ad21793144..4fc19c4a121499b1054875a3c5c0405222b2af87 100644 (file)
--- a/source3/utils/net.c
+++ b/source3/utils/net.c
@@ -1427,6 +1427,7 @@ static void get_credentials_file(struct net_context *c,
 
        poptFreeContext(pc);
 
+       cmdline_messaging_context_free();
        TALLOC_FREE(frame);
        return rc;
 }

diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
index 5232c2b59cea2f783136cc86dc6eaf518c2c34b6..e5a6e986d82676ef979f9cdebe4e596841d2b643 100644 (file)
--- a/source3/utils/smbcontrol.c
+++ b/source3/utils/smbcontrol.c
@@ -1775,6 +1775,7 @@ int main(int argc, const char **argv)
 
        ret = !do_command(evt_ctx, msg_ctx, argc, argv);
 
+       cmdline_messaging_context_free();
        poptFreeContext(pc);
        TALLOC_FREE(frame);
        return ret;

diff --git a/source3/utils/status.c b/source3/utils/status.c
index 59f09b771601e983178bca0523d8110f20662f6f..fc21d20f766dd105dfc7fd183028bece3ae431b7 100644 (file)
--- a/source3/utils/status.c
+++ b/source3/utils/status.c
@@ -835,6 +835,7 @@ int main(int argc, const char *argv[])
        }
 
 done:
+       cmdline_messaging_context_free();
        poptFreeContext(pc);
        TALLOC_FREE(frame);
        return ret;