]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mailbox: mtk-cmdq: fix wrong use of sizeof in cmdq_get_clocks()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 29 Oct 2024 13:16:28 +0000 (21:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:53:44 +0000 (13:53 +0100)
[ Upstream commit 271ee263cc8771982809185007181ca10346fe73 ]

It should be size of the struct clk_bulk_data, not data pointer pass to
devm_kcalloc().

Fixes: aa1609f571ca ("mailbox: mtk-cmdq: Dynamically allocate clk_bulk_data structure")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mailbox/mtk-cmdq-mailbox.c

index 4bff73532085bdc6cf5004d8b7495ad8ec2d9157..9c43ed9bdd37b52079e4ef33fe6d852a805a15cb 100644 (file)
@@ -584,7 +584,7 @@ static int cmdq_get_clocks(struct device *dev, struct cmdq *cmdq)
        struct clk_bulk_data *clks;
 
        cmdq->clocks = devm_kcalloc(dev, cmdq->pdata->gce_num,
-                                   sizeof(cmdq->clocks), GFP_KERNEL);
+                                   sizeof(*cmdq->clocks), GFP_KERNEL);
        if (!cmdq->clocks)
                return -ENOMEM;