amd-xgbe: add adaptive link status polling

Implement adaptive link status polling to enable fast link-down detection
while conserving CPU resources during link-down periods.

Currently, the driver polls link status at a fixed 1-second interval
regardless of link state. This creates a trade-off:
  - Slow polling (1s): Misses rapid link state changes, causing delays
  - Fast polling: Wastes CPU when link is stable or down

This enhancement introduces state-aware polling:

When carrier is UP:
  Poll every 100ms to enable rapid link-down detection. This provides
  ~100-200ms response time to link failures, minimizing packet loss and
  enabling fast failover in link aggregation configurations.

When carrier is DOWN:
  Poll every 1s to conserve CPU resources. Link-up detection is less
  time-critical since no traffic is flowing.

Performance impact:
  - Link-down detection: 1000ms → 100-200ms (10x improvement)
  - CPU overhead when link up: 0.1% → 1% (acceptable for active links)
  - CPU overhead when link down: unchanged at 0.1%

This is particularly valuable for:
  - Link aggregation deployments requiring sub-second failover
  - Environments with flaky links or cable issues
  - Applications sensitive to connection recovery time

Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Link: https://patch.msgid.link/20260319163251.1808611-2-Raju.Rangoju@amd.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index 2f39f38fecf9f9d9dc10e293f0426cc8bcf8006c..6886d3b33ffe059f7f38519ae42eba6e24ced57b 100644 (file)
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -607,11 +607,33 @@ static void xgbe_service_timer(struct timer_list *t)
        struct xgbe_prv_data *pdata = timer_container_of(pdata, t,
                                                         service_timer);
        struct xgbe_channel *channel;
+       unsigned int poll_interval;
        unsigned int i;
 
        queue_work(pdata->dev_workqueue, &pdata->service_work);
 
-       mod_timer(&pdata->service_timer, jiffies + HZ);
+       /* Adaptive link status polling for fast failure detection:
+        *
+        * - When carrier is UP: poll every 100ms for rapid link-down detection
+        *   Enables sub-second response to link failures, minimizing traffic
+        *   loss.
+        *
+        * - When carrier is DOWN: poll every 1s to conserve CPU resources
+        *   Link-up events are less time-critical.
+        *
+        * The 100ms active polling interval balances responsiveness with
+        * efficiency:
+        * - Provides ~100-200ms link-down detection (10x faster than 1s
+        *   polling)
+        * - Minimal CPU overhead (1% vs 0.1% with 1s polling)
+        * - Enables fast failover in link aggregation deployments
+        */
+       if (netif_running(pdata->netdev) && netif_carrier_ok(pdata->netdev))
+               poll_interval = msecs_to_jiffies(100);  /* 100ms when up */
+       else
+               poll_interval = HZ;  /* 1 second when down */
+
+       mod_timer(&pdata->service_timer, jiffies + poll_interval);
 
        if (!pdata->tx_usecs)
                return;