device: remove some unnecessary unsafe

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>

diff --git a/device/indextable.go b/device/indextable.go
index 5e10eef3ff483db80c1e2d061972ad9766da65b5..d2dc8a7ce98a4b2280917ea3a921e4c1b735c385 100644 (file)
--- a/device/indextable.go
+++ b/device/indextable.go
@@ -7,8 +7,8 @@ package device
 
 import (
        "crypto/rand"
+       "encoding/binary"
        "sync"
-       "unsafe"
 )
 
 type IndexTableEntry struct {
@@ -25,7 +25,8 @@ type IndexTable struct {
 func randUint32() (uint32, error) {
        var integer [4]byte
        _, err := rand.Read(integer[:])
-       return *(*uint32)(unsafe.Pointer(&integer[0])), err
+       // Arbitrary endianness; both are intrinsified by the Go compiler.
+       return binary.LittleEndian.Uint32(integer[:]), err
 }
 
 func (table *IndexTable) Init() {