]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Don't validate non-pending glue when adding to the additional section
authorMukund Sivaraman <muks@isc.org>
Wed, 2 May 2018 06:48:44 +0000 (12:18 +0530)
committerOndřej Surý <ondrej@sury.org>
Wed, 16 May 2018 06:15:36 +0000 (08:15 +0200)
lib/ns/query.c

index 21f1860bb61ba8c13bc14d35ad1b51434813710f..d6e9a4dffdc6827804dc3248c539e726430ca219 100644 (file)
@@ -1880,8 +1880,7 @@ query_addadditional(void *arg, const dns_name_t *name, dns_rdatatype_t qtype) {
                        mname = NULL;
                        have_a = ISC_TRUE;
                        if (additionaltype == dns_rdatasetadditional_fromcache &&
-                           (DNS_TRUST_PENDING(rdataset->trust) ||
-                            DNS_TRUST_GLUE(rdataset->trust)) &&
+                           DNS_TRUST_PENDING(rdataset->trust) &&
                            !validate(client, db, fname, rdataset, sigrdataset))
                        {
                                dns_rdataset_disassociate(rdataset);
@@ -1945,8 +1944,7 @@ query_addadditional(void *arg, const dns_name_t *name, dns_rdatatype_t qtype) {
                              !dns_rdataset_isassociated(sigrdataset)))))
                                goto addname;
                        if (additionaltype == dns_rdatasetadditional_fromcache &&
-                           (DNS_TRUST_PENDING(rdataset->trust) ||
-                            DNS_TRUST_GLUE(rdataset->trust)) &&
+                           DNS_TRUST_PENDING(rdataset->trust) &&
                            !validate(client, db, fname, rdataset, sigrdataset))
                        {
                                dns_rdataset_disassociate(rdataset);