iio: core: add missing mutex_destroy in iio_dev_release()

[ Upstream commit f5d203467a31798191365efeb16cd619d2c8f23a ]

Add missing mutex_destroy() call in iio_dev_release() to properly
clean up the mutex initialized in iio_device_alloc(). Ensure proper
resource cleanup and follows kernel practices.

Found by code review.

While at it, create a lockdep key before mutex initialisation.
This will help with converting it to the better API in the future.

Fixes: 847ec80bbaa7 ("Staging: IIO: core support for device registration and management")
Fixes: ac917a81117c ("staging:iio:core set the iio_dev.info pointer to null on unregister under lock.")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Stable-dep-of: 9910159f0659 ("iio: core: add separate lockdep class for info_exist_lock")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 121bde49ccb7d43b429e3abb2c9c35612cb163c1..00a82f1688375c386670d1145561c547d541f185 100644 (file)
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -1618,6 +1618,9 @@ static void iio_dev_release(struct device *device)
 
        iio_device_detach_buffers(indio_dev);
 
+       mutex_destroy(&iio_dev_opaque->info_exist_lock);
+       mutex_destroy(&iio_dev_opaque->mlock);
+
        lockdep_unregister_key(&iio_dev_opaque->mlock_key);
 
        ida_free(&iio_ida, iio_dev_opaque->id);
@@ -1663,8 +1666,7 @@ struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv)
        indio_dev->dev.type = &iio_device_type;
        indio_dev->dev.bus = &iio_bus_type;
        device_initialize(&indio_dev->dev);
-       mutex_init(&iio_dev_opaque->mlock);
-       mutex_init(&iio_dev_opaque->info_exist_lock);
+
        INIT_LIST_HEAD(&iio_dev_opaque->channel_attr_list);
 
        iio_dev_opaque->id = ida_alloc(&iio_ida, GFP_KERNEL);
@@ -1687,6 +1689,9 @@ struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv)
        lockdep_register_key(&iio_dev_opaque->mlock_key);
        lockdep_set_class(&iio_dev_opaque->mlock, &iio_dev_opaque->mlock_key);
 
+       mutex_init(&iio_dev_opaque->mlock);
+       mutex_init(&iio_dev_opaque->info_exist_lock);
+
        return indio_dev;
 }
 EXPORT_SYMBOL(iio_device_alloc);