test_read_format_rar5: correctly use verify_data()

Reported by: CodeQL
Code Scanning Alert: 129

diff --git a/libarchive/test/test_read_format_rar5.c b/libarchive/test/test_read_format_rar5.c
index 0c3028971bbc9d86433b4ef60d1fbbcf281b1fca..54aae0ed17846d36d7307e0d0ce13b5e93acd23b 100644 (file)
--- a/libarchive/test/test_read_format_rar5.c
+++ b/libarchive/test/test_read_format_rar5.c
@@ -168,7 +168,7 @@ DEFINE_TEST(test_read_format_rar5_compressed)
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
        assertA(ARCHIVE_EOF == archive_read_next_header(a, &ae));
-       verify_data(buff, 0, DATA_SIZE);
+       assertA(1 == verify_data(buff, 0, DATA_SIZE));
 
        EPILOGUE();
 }
@@ -187,25 +187,25 @@ DEFINE_TEST(test_read_format_rar5_multiple_files)
        assertEqualString("test1.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 1, DATA_SIZE));
+       assertA(1 == verify_data(buff, 1, DATA_SIZE));
 
        assertA(0 == archive_read_next_header(a, &ae));
        assertEqualString("test2.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 2, DATA_SIZE));
+       assertA(1 == verify_data(buff, 2, DATA_SIZE));
 
        assertA(0 == archive_read_next_header(a, &ae));
        assertEqualString("test3.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 3, DATA_SIZE));
+       assertA(1 == verify_data(buff, 3, DATA_SIZE));
 
        assertA(0 == archive_read_next_header(a, &ae));
        assertEqualString("test4.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 4, DATA_SIZE));
+       assertA(1 == verify_data(buff, 4, DATA_SIZE));
 
        /* There should be no more files in this archive. */
 
@@ -230,25 +230,25 @@ DEFINE_TEST(test_read_format_rar5_multiple_files_solid)
        assertEqualString("test1.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 1, DATA_SIZE));
+       assertA(1 == verify_data(buff, 1, DATA_SIZE));
 
        assertA(0 == archive_read_next_header(a, &ae));
        assertEqualString("test2.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 2, DATA_SIZE));
+       assertA(1 == verify_data(buff, 2, DATA_SIZE));
 
        assertA(0 == archive_read_next_header(a, &ae));
        assertEqualString("test3.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 3, DATA_SIZE));
+       assertA(1 == verify_data(buff, 3, DATA_SIZE));
 
        assertA(0 == archive_read_next_header(a, &ae));
        assertEqualString("test4.bin", archive_entry_pathname(ae));
        assertEqualInt(DATA_SIZE, archive_entry_size(ae));
        assertA(DATA_SIZE == archive_read_data(a, buff, DATA_SIZE));
-       assertA(verify_data(buff, 4, DATA_SIZE));
+       assertA(1 == verify_data(buff, 4, DATA_SIZE));
 
        assertA(ARCHIVE_EOF == archive_read_next_header(a, &ae));
        EPILOGUE();