Bug 282510: Argument "" isn't numeric when modifying group

Patch by Byron Jones <bugzilla@glob.com.au> r,a=justdave

diff --git a/editgroups.cgi b/editgroups.cgi
index 02f24b1e4ddfc313b2b0ce467bf6ca43871fb39a..f7362cb5fa2c4d8eac892c56bafe88378b8aa986 100755 (executable)
--- a/editgroups.cgi
+++ b/editgroups.cgi
@@ -599,7 +599,7 @@ sub doGroupChanges {
             $b =~ /^oldgrp-(\d+)$/;
             my $v = $1;
             my $grp = $cgi->param("grp-$v") || 0;
-            if (($cgi->param("oldgrp-$v") != $grp) && ($v != $gid)) {
+            if (($v != $gid) && ($cgi->param("oldgrp-$v") != $grp)) {
                 $chgs = 1;
                 if ($grp != 0) {
                     SendSQL("INSERT INTO group_group_map 
@@ -613,7 +613,8 @@ sub doGroupChanges {
             }
 
             my $bless = $cgi->param("bless-$v") || 0;
-            if ($cgi->param("oldbless-$v") != $bless) {
+            my $oldbless = $cgi->param("oldbless-$v");
+            if ((defined $oldbless) and ($oldbless != $bless)) {
                 $chgs = 1;
                 if ($bless != 0) {
                     SendSQL("INSERT INTO group_group_map 

diff --git a/template/en/default/admin/groups/edit.html.tmpl b/template/en/default/admin/groups/edit.html.tmpl
index 92b8e9c2ee40d72aee5b2a6acedfbc74bb69894a..610d3102ef0da7a0f569b110f5fa9cc9522c6528 100644 (file)
--- a/template/en/default/admin/groups/edit.html.tmpl
+++ b/template/en/default/admin/groups/edit.html.tmpl
@@ -154,9 +154,10 @@
           </td>
         [% ELSE %]
           <td>
+            <input type="hidden" name="oldbless-[% group.grpid FILTER html %]" value="0">
           </td>
           <td>
-            <input type="hidden" name="oldgrp-[% group.grpid FILTER html %]" value="">
+            <input type="hidden" name="oldgrp-[% group.grpid FILTER html %]" value="0">
           </td>
         [% END %]
         <td align="left" class="groupname">