]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: mt76: fix of_get_mac_address error handling
authorRosen Penev <rosenp@gmail.com>
Mon, 27 Apr 2026 05:17:46 +0000 (22:17 -0700)
committerFelix Fietkau <nbd@nbd.name>
Tue, 9 Jun 2026 10:15:19 +0000 (10:15 +0000)
Check return value instead of is_valid_ether_addr. The latter is handled
by the former.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20260427051746.954704-1-rosenp@gmail.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/eeprom.c

index afdb73661866e9c2b17b98a885eee3ad9940fdce..b99d7452800fdee89da428103d07a562f43195a7 100644 (file)
@@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy)
        if (err == -EPROBE_DEFER)
                return err;
 
-       if (!is_valid_ether_addr(phy->macaddr)) {
+       if (err) {
                eth_random_addr(phy->macaddr);
                dev_info(dev->dev,
                         "Invalid MAC address, using random address %pM\n",