memcmp: no-simd no case loop can scan forward

(cherry picked from commit f0479987ff6f5321613395a8bf1a5eb38530b977)

diff --git a/src/util-memcmp.h b/src/util-memcmp.h
index 847560e20b76a856f6756ca9c960433fa4ff460f..a54e6f5125097886bbe54b0fc3293ee737c85281 100644 (file)
--- a/src/util-memcmp.h
+++ b/src/util-memcmp.h
@@ -41,13 +41,8 @@ void MemcmpRegisterTests(void);
 static inline int
 MemcmpLowercase(const void *s1, const void *s2, size_t n)
 {
-    ssize_t i;
-
-    /* check backwards because we already tested the first
-     * 2 to 4 chars. This way we are more likely to detect
-     * a miss and thus speed up a little... */
-    for (i = n - 1; i >= 0; i--) {
-        if (((uint8_t *)s1)[i] != u8_tolower(*(((uint8_t *)s2)+i)))
+    for (size_t i = 0; i < n; i++) {
+        if (((uint8_t *)s1)[i] != u8_tolower(((uint8_t *)s2)[i]))
             return 1;
     }