]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: phy-snps-eusb2: fix repeater imbalance on phy_init() failure
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 23 May 2025 08:48:34 +0000 (10:48 +0200)
committerVinod Koul <vkoul@kernel.org>
Sun, 15 Jun 2025 16:32:41 +0000 (22:02 +0530)
Make sure to disable the repeater PHY also on phy_init() failure.

Fixes: 3584f6392f09 ("phy: qcom: phy-qcom-snps-eusb2: Add support for eUSB2 repeater")
Cc: Abel Vesa <abel.vesa@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20250523084839.11015-3-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-snps-eusb2.c

index 19af3f99692c73f3b9c1f86dd0d9f07d4b38f297..a799c3d2bcfbdbe5fb3105dc11c567ac2f687035 100644 (file)
@@ -468,7 +468,7 @@ static int snps_eusb2_hsphy_init(struct phy *p)
        ret = clk_bulk_prepare_enable(phy->data->num_clks, phy->clks);
        if (ret) {
                dev_err(&p->dev, "failed to enable ref clock, %d\n", ret);
-               goto disable_vreg;
+               goto exit_repeater;
        }
 
        ret = reset_control_assert(phy->phy_reset);
@@ -493,7 +493,8 @@ static int snps_eusb2_hsphy_init(struct phy *p)
 
 disable_ref_clk:
        clk_bulk_disable_unprepare(phy->data->num_clks, phy->clks);
-
+exit_repeater:
+       phy_exit(phy->repeater);
 disable_vreg:
        regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs);