]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix KCM client time offset propagation 969/head
authorRobbie Harwood <rharwood@redhat.com>
Wed, 14 Aug 2019 17:52:27 +0000 (13:52 -0400)
committerGreg Hudson <ghudson@mit.edu>
Thu, 15 Aug 2019 17:10:23 +0000 (13:10 -0400)
An inverted status check in get_kdc_offset() would cause querying the
offset time from the ccache to always fail (silently) on KCM.  Fix the
status check so that KCM can properly handle desync.

ticket: 8826 (new)
tags: pullup
target_version: 1.17-next
target_verison: 1.16-next

src/lib/krb5/ccache/cc_kcm.c

index 103cd98ac17c009fad511a056171cc47b91934ca..1f5d6c834560a9e0c9a42da5227ae1bd84ed0381 100644 (file)
@@ -577,7 +577,7 @@ get_kdc_offset(krb5_context context, krb5_ccache cache)
     if (cache_call(context, cache, &req) != 0)
         goto cleanup;
     time_offset = k5_input_get_uint32_be(&req.reply);
-    if (!req.reply.status)
+    if (req.reply.status)
         goto cleanup;
     context->os_context.time_offset = time_offset;
     context->os_context.usec_offset = 0;