]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
soc: samsung: exynos-pmu: Annotate online/offline functions with __must_hold
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 5 Sep 2025 17:37:18 +0000 (19:37 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 13 Oct 2025 00:58:51 +0000 (02:58 +0200)
Annotate functions writing to PMU registers to online and offline CPUs
as __must_hold() the necessary spinlock for code correctness.  These are
static functions so possibility of mistakes is low here, but
__must_hold() serves as self-documenting code.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/soc/samsung/exynos-pmu.c

index 22c50ca2aa79bf1945255ee6cc7443d7309b2573..105293970d48648c08a55670e9198af5b2260ff1 100644 (file)
@@ -364,6 +364,7 @@ EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap_by_phandle);
  * disabled and cpupm_lock held.
  */
 static int __gs101_cpu_pmu_online(unsigned int cpu)
+       __must_hold(&pmu_context->cpupm_lock)
 {
        unsigned int cpuhint = smp_processor_id();
        u32 reg, mask;
@@ -424,6 +425,7 @@ static int gs101_cpuhp_pmu_online(unsigned int cpu)
 
 /* Common function shared by both CPU hot plug and CPUIdle */
 static int __gs101_cpu_pmu_offline(unsigned int cpu)
+       __must_hold(&pmu_context->cpupm_lock)
 {
        unsigned int cpuhint = smp_processor_id();
        u32 reg, mask;