]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
libbpf: Fix output .symtab byte-order during linking
authorTony Ambardar <tony.ambardar@gmail.com>
Mon, 16 Sep 2024 08:37:42 +0000 (01:37 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:53:11 +0000 (13:53 +0100)
[ Upstream commit f896b4a5399e97af0b451fcf04754ed316935674 ]

Object linking output data uses the default ELF_T_BYTE type for '.symtab'
section data, which disables any libelf-based translation. Explicitly set
the ELF_T_SYM type for output to restore libelf's byte-order conversion,
noting that input '.symtab' data is already correctly translated.

Fixes: faf6ed321cf6 ("libbpf: Add BPF static linker APIs")
Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/87868bfeccf3f51aec61260073f8778e9077050a.1726475448.git.tony.ambardar@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/lib/bpf/linker.c

index 9cd3d4109788c07a13f2210a63cdbb4f3ce62590..7489306cd6f7fdace4f4808407e4f08e8bc8b410 100644 (file)
@@ -396,6 +396,8 @@ static int init_output_elf(struct bpf_linker *linker, const char *file)
                pr_warn_elf("failed to create SYMTAB data");
                return -EINVAL;
        }
+       /* Ensure libelf translates byte-order of symbol records */
+       sec->data->d_type = ELF_T_SYM;
 
        str_off = strset__add_str(linker->strtab_strs, sec->sec_name);
        if (str_off < 0)