]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/libsmb: clang: Fix 2nd function call argument is an uninitialized value
authorNoel Power <noel.power@suse.com>
Thu, 8 Aug 2019 14:24:16 +0000 (15:24 +0100)
committerGary Lockyer <gary@samba.org>
Wed, 28 Aug 2019 01:47:40 +0000 (01:47 +0000)
source3/libsmb/namequery.c:2719:11: warning: 2nd function call argument is an uninitialized value <--[clang]
                                        if (!convert_ss2service(return_iplist,
                                             ^
source3/libsmb/namequery.c:2733:10: warning: 2nd function call argument is an uninitialized value <--[clang]
                                if (!convert_ss2service(return_iplist,
                                     ^
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source3/libsmb/namequery.c

index bb9585dd402fb8824f51c5646124f8d7d3123432..5c93c60a3718006c1c5f4e229d603af840b08254 100644 (file)
@@ -2709,7 +2709,7 @@ NTSTATUS internal_resolve_name(const char *name,
                        }
                } else if (strequal(tok, "wins")) {
                        /* don't resolve 1D via WINS */
-                       struct sockaddr_storage *ss_list;
+                       struct sockaddr_storage *ss_list = NULL;
                        if (name_type != 0x1D) {
                                status = resolve_wins(name, name_type,
                                                      talloc_tos(),
@@ -2725,7 +2725,7 @@ NTSTATUS internal_resolve_name(const char *name,
                                }
                        }
                } else if (strequal(tok, "bcast")) {
-                       struct sockaddr_storage *ss_list;
+                       struct sockaddr_storage *ss_list = NULL;
                        status = name_resolve_bcast(
                                name, name_type, talloc_tos(),
                                &ss_list, return_count);