ASoC: codecs: wcd938x: fix OF node leaks on probe failure

The component match entry release function will drop the references
taken while looking up the soundwire OF nodes when the platform device
is unbound.

Drop the additional references taken to avoid leaking them on probe
failure (e.g. probe deferral) and on driver unbind.

Fixes: 8d78602aa87a ("ASoC: codecs: wcd938x: add basic driver")
Cc: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251201093419.24474-3-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index f5b7de2bc896da7ea5dc9df60d50650ab7498b20..cb0a0bfdb6e322927a4d162cbc5ef924ef3c215b 100644 (file)
--- a/sound/soc/codecs/wcd938x.c
+++ b/sound/soc/codecs/wcd938x.c
@@ -3464,7 +3464,6 @@ static int wcd938x_add_slave_components(struct wcd938x_priv *wcd938x,
                return -ENODEV;
        }
 
-       of_node_get(wcd938x->rxnode);
        component_match_add_release(dev, matchptr, component_release_of,
                                    component_compare_of, wcd938x->rxnode);
 
@@ -3473,7 +3472,7 @@ static int wcd938x_add_slave_components(struct wcd938x_priv *wcd938x,
                dev_err(dev, "%s: Tx-device node not defined\n", __func__);
                return -ENODEV;
        }
-       of_node_get(wcd938x->txnode);
+
        component_match_add_release(dev, matchptr, component_release_of,
                                    component_compare_of, wcd938x->txnode);
        return 0;