]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: ca0106: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:06:35 +0000 (12:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:18 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-54-tiwai@suse.de
sound/pci/ca0106/ca0106_main.c
sound/pci/ca0106/ca0106_mixer.c
sound/pci/ca0106/ca_midi.c

index 7c7119cad63cd7eba0ffe430986993dc68f95e47..242618793181879559e6133187cc6dacd7d8dbe5 100644 (file)
@@ -1315,7 +1315,7 @@ static int snd_ca0106_pcm(struct snd_ca0106 *emu, int device)
         }
 
        pcm->info_flags = 0;
-       strcpy(pcm->name, "CA0106");
+       strscpy(pcm->name, "CA0106");
 
        for(substream = pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream; 
            substream; 
@@ -1617,8 +1617,8 @@ static int snd_ca0106_create(int dev, struct snd_card *card,
        pci_read_config_word(pci, PCI_SUBSYSTEM_ID, &chip->model);
        dev_info(card->dev, "Model %04x Rev %08x Serial %08x\n",
               chip->model, pci->revision, chip->serial);
-       strcpy(card->driver, "CA0106");
-       strcpy(card->shortname, "CA0106");
+       strscpy(card->driver, "CA0106");
+       strscpy(card->shortname, "CA0106");
 
        for (c = ca0106_chip_details; c->serial; c++) {
                if (subsystem[dev]) {
index 1d5a899b2c243183d75574c7c27715b15a4fe500..f7b6b2db889b10231a6275258a69b3e300fb42e0 100644 (file)
@@ -701,7 +701,7 @@ static int remove_ctl(struct snd_card *card, const char *name)
 {
        struct snd_ctl_elem_id id;
        memset(&id, 0, sizeof(id));
-       strcpy(id.name, name);
+       strscpy(id.name, name);
        id.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
        return snd_ctl_remove_id(card, &id);
 }
@@ -849,7 +849,7 @@ int snd_ca0106_mixer(struct snd_ca0106 *emu)
                        return err;
        }
 
-       strcpy(card->mixername, "CA0106");
+       strscpy(card->mixername, "CA0106");
         return 0;
 }
 
index 957e60f648211c03223d263159d042a60bfcfdc2..f9cec67f31ac671eaf81d6dec870f81e3796e1d4 100644 (file)
@@ -287,7 +287,7 @@ int ca_midi_init(void *dev_id, struct snd_ca_midi *midi, int device, char *name)
        spin_lock_init(&midi->input_lock);
        spin_lock_init(&midi->output_lock);
 
-       strcpy(rmidi->name, name);
+       strscpy(rmidi->name, name);
        snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT, &ca_midi_output);
        snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_INPUT, &ca_midi_input);
        rmidi->info_flags |= SNDRV_RAWMIDI_INFO_OUTPUT |