efi_loader: Improve EFI variable load message

Change the EFI variable load message from log_err() to log_info() with
neutral wording. The previous "Failed to load" message caused customer
confusion as it appeared to indicate an error condition.

The efi_var_from_file() function deliberately returns EFI_SUCCESS in
this case to allow the boot process to continue normally. This is
documented in the function's comment block but was not reflected in
the log message level or content.

The message now uses informational wording to reflect that this is
normal behavior when the ubootefi.var file does not yet exist.

Signed-off-by: Pranav Tilak <pranav.vinaytilak@amd.com>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

diff --git a/lib/efi_loader/efi_var_file.c b/lib/efi_loader/efi_var_file.c
index ba0bf33ffbd11a2d54bf37469c25d03f420f5e27..f23a964a4180cf1fbfd9c8fa0a79279593b0a537 100644 (file)
--- a/lib/efi_loader/efi_var_file.c
+++ b/lib/efi_loader/efi_var_file.c
@@ -173,7 +173,7 @@ efi_status_t efi_var_from_file(void)
        r = fs_read(EFI_VAR_FILE_NAME, map_to_sysmem(buf), 0, EFI_VAR_BUF_SIZE,
                    &len);
        if (r || len < sizeof(struct efi_var_file)) {
-               log_err("Failed to load EFI variables\n");
+               log_info("No EFI variables loaded\n");
                goto error;
        }
        if (buf->length != len || efi_var_restore(buf, false) != EFI_SUCCESS)