]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
A couple more Coverity issues fixed
authorSteve Underwood <steveu@coppice.org>
Wed, 30 Apr 2014 17:19:28 +0000 (01:19 +0800)
committerSteve Underwood <steveu@coppice.org>
Wed, 30 Apr 2014 17:19:28 +0000 (01:19 +0800)
libs/spandsp/src/at_interpreter.c
libs/spandsp/src/t43.c
libs/spandsp/src/v42.c

index dbe490badde0a0055d1807b9899ff87da9f8b68e..c009a19a5240de615f4f7cf954d0e1f3cde40492 100644 (file)
@@ -726,11 +726,18 @@ static int parse_string_list_out(at_state_t *s, const char **t, int *target, int
         val = (target)  ?  *target  :  0;
         while (val--  &&  (def = strchr(def, ',')))
             def++;
-        if ((tmp = strchr(def, ',')))
-            len = tmp - def;
+        if (def)
+        {
+            if ((tmp = strchr(def, ',')))
+                len = tmp - def;
+            else
+                len = strlen(def);
+            snprintf(buf, sizeof(buf), "%s%.*s", (prefix)  ?  prefix  :  "", (int) len, def);
+        }
         else
-            len = strlen(def);
-        snprintf(buf, sizeof(buf), "%s%.*s", (prefix)  ?  prefix  :  "", (int) len, def);
+        {
+            buf[0] = '\0';
+        }
         at_put_response(s, buf);
         break;
     default:
index 13b19a146f1c7ba92cf4f81a54c7cc8dd9d8cab1..8735bd01ffcc1bc827f3db5dad6816fec53a85f8 100644 (file)
@@ -381,7 +381,7 @@ SPAN_DECLARE(int) t43_encode_free(t43_encode_state_t *s)
 {
     int ret;
 
-    t85_encode_free(&s->t85);
+    t85_encode_release(&s->t85);
     ret = t43_encode_release(s);
     span_free(s);
     return ret;
index c52a9676a228aaec0a487fc26e5f557d34b6ed0d..388f69e66fe812196411ce39b9fde5117a208339 100644 (file)
@@ -1099,8 +1099,6 @@ SPAN_DECLARE_NONSTD(void) lapm_receive(void *user_data, const uint8_t *frame, in
         else
             rx_unnumbered_rsp_frame(ss, frame, len);
         break;
-    default:
-        break;
     }
 }
 /*- End of function --------------------------------------------------------*/