cgrulesengd: Fixed closing of daemon sockets on error

When socket() fails, it returns -1 instead of file descriptor and we might pass
this -1 to close() in close_and_exit label -> unexpected result.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>

diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c
index 2f42a57b826594385a8aafcaf2cbaf990fa6085c..ff729651a922bfa1003ac83b400d9a3cbb1bdadc 100644 (file)
--- a/src/daemon/cgrulesengd.c
+++ b/src/daemon/cgrulesengd.c
@@ -722,9 +722,9 @@ static int cgre_create_netlink_socket_process_msg(void)
        }
 
 close_and_exit:
-       if (sk_nl)
+       if (sk_nl > 0)
                close(sk_nl);
-       if (sk_unix)
+       if (sk_unix > 0)
                close(sk_unix);
        return rc;
 }