selftests/mm: don't compare return values to in cow

Tweak the coding style for checking for non-zero return values.
While we're at it also remove a now redundant oring of the madvise()
return code.

Link: https://lkml.kernel.org/r/20250610-selftest-mm-cow-tweaks-v1-3-43cd7457500f@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Suggested-by: David Hildenbrand <david@redhat.com>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c
index ff80329313e4a62070a94952019680b180c4de66..48fcf03aa4cd985f423589b890c21046b517fa1e 100644 (file)
--- a/tools/testing/selftests/mm/cow.c
+++ b/tools/testing/selftests/mm/cow.c
@@ -1613,13 +1613,13 @@ static void run_with_huge_zeropage(non_anon_test_fn fn, const char *desc)
        smem = (char *)(((uintptr_t)mmap_smem + pmdsize) & ~(pmdsize - 1));
 
        ret = madvise(mem, pmdsize, MADV_HUGEPAGE);
-       if (ret != 0) {
+       if (ret) {
                ksft_perror("madvise()");
                log_test_result(KSFT_FAIL);
                goto munmap;
        }
-       ret |= madvise(smem, pmdsize, MADV_HUGEPAGE);
-       if (ret != 0) {
+       ret = madvise(smem, pmdsize, MADV_HUGEPAGE);
+       if (ret) {
                ksft_perror("madvise()");
                log_test_result(KSFT_FAIL);
                goto munmap;