]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: gadget: pxa25x_udc: Switch to use devm_gpio_request_one()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Sat, 31 May 2025 21:21:38 +0000 (00:21 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 10 Jun 2025 07:59:54 +0000 (09:59 +0200)
devm_gpio_request() is going to be removed. This driver is only user of that
API. Convert it to use different API.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250531212331.3635269-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/usb/gadget/udc/pxa25x_udc.c

index f5d09a91e55469d69b5c864434ee586bfd7486b0..b97fb7b0cb2c202a18204510251be6f1f43c204a 100644 (file)
@@ -2348,15 +2348,14 @@ static int pxa25x_udc_probe(struct platform_device *pdev)
        dev->transceiver = devm_usb_get_phy(&pdev->dev, USB_PHY_TYPE_USB2);
 
        if (gpio_is_valid(dev->mach->gpio_pullup)) {
-               retval = devm_gpio_request(&pdev->dev, dev->mach->gpio_pullup,
-                                          "pca25x_udc GPIO PULLUP");
+               retval = devm_gpio_request_one(&pdev->dev, dev->mach->gpio_pullup,
+                                              GPIOF_OUT_INIT_LOW, "pca25x_udc GPIO PULLUP");
                if (retval) {
                        dev_dbg(&pdev->dev,
                                "can't get pullup gpio %d, err: %d\n",
                                dev->mach->gpio_pullup, retval);
                        goto err;
                }
-               gpio_direction_output(dev->mach->gpio_pullup, 0);
        }
 
        timer_setup(&dev->timer, udc_watchdog, 0);