]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-common: Disconnect reason - Move auth_process_comm_fail check earlier
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Thu, 22 Dec 2022 11:55:05 +0000 (13:55 +0200)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Thu, 23 Mar 2023 08:06:31 +0000 (08:06 +0000)
Likely doesn't matter, but this is more important reason to be logged than
the ones coming later.

src/login-common/client-common.c

index a299d54734044187b285b76de8d57d9b3a585e64..8194c144d1e8428ce87087e0617c453985e5fe4d 100644 (file)
@@ -1136,6 +1136,9 @@ const char *client_get_extra_disconnect_reason(struct client *client)
                        (unsigned int)(ioloop_time - client->created.tv_sec));
        }
 
+       if (client->auth_process_comm_fail)
+               return "auth process communication failure";
+
        if (client->auth_client_continue_pending && client->auth_attempts == 1) {
                return t_strdup_printf("client didn't finish SASL auth, "
                                       "waited %u secs", auth_secs);
@@ -1150,8 +1153,6 @@ const char *client_get_extra_disconnect_reason(struct client *client)
        }
        if (client->auth_aborted_by_client && client->auth_attempts == 1)
                return "auth aborted by client";
-       if (client->auth_process_comm_fail)
-               return "auth process communication failure";
 
        if (client->auth_nologin_referral)
                return "auth referral";