]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: atomisp: gmin: Remove duplicate NULL test
authorAbraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Thu, 3 Apr 2025 13:26:41 +0000 (14:26 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 5 May 2025 07:47:27 +0000 (09:47 +0200)
When a value has been tested for NULL in an expression, a
second NULL test on the same value in another expression
is unnecessary when the value has not been assigned NULL.

Remove unnecessary duplicate NULL tests on the same value that
has previously been NULL tested.

Found by Coccinelle.

Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Link: https://lore.kernel.org/r/26990d4a9d4419f9d4155a40595bc213acb671a0.1743685415.git.abrahamadekunle50@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

index e7923dc38f2e5eb4dec9e03d40e80b9c6895ff39..b4f2c785e6a611d987becbd50c03b96677012818 100644 (file)
@@ -1206,7 +1206,7 @@ static int gmin_get_config_dsm_var(struct device *dev,
         * if it founds something different than string, letting it
         * to fall back to the old code.
         */
-       if (cur && cur->type != ACPI_TYPE_STRING) {
+       if (cur->type != ACPI_TYPE_STRING) {
                dev_info(dev, "found non-string _DSM entry for '%s'\n", var);
                ACPI_FREE(obj);
                return -EINVAL;