]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
gtkmodule: Improve error message for invalid signal element in ui-file
authorYotam Nachum <me@yotam.net>
Sat, 6 Nov 2021 12:33:07 +0000 (14:33 +0200)
committerRico Tzschichholz <ricotz@ubuntu.com>
Sun, 14 Nov 2021 12:08:07 +0000 (13:08 +0100)
codegen/valagtkmodule.vala

index 2f3431653ae6a71c311becff60d1bf963bb32a30..a8b0d31c0dfd131ee39ac58e5b212500488b0a38 100644 (file)
@@ -184,7 +184,13 @@ public class Vala.GtkModule : GSignalModule {
 
                                if (current_class != null) {
                                        if (signal_name == null || handler_name == null) {
-                                               Report.error (node.source_reference, "Invalid signal in ui file `%s'".printf (ui_file));
+                                               if (signal_name != null) {
+                                                       Report.error (node.source_reference, "Invalid signal `%s' without handler in ui file `%s'".printf (signal_name, ui_file));
+                                               } else if (handler_name != null) {
+                                                       Report.error (node.source_reference, "Invalid signal without name in ui file `%s'".printf (ui_file));
+                                               } else {
+                                                       Report.error (node.source_reference, "Invalid signal without name and handler in ui file `%s'".printf (ui_file));
+                                               }
                                                current_token = reader.read_token (null, null);
                                                continue;
                                        }