]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data"
authorYueHaibing <yuehaibing@huawei.com>
Tue, 29 Jan 2019 08:03:24 +0000 (16:03 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:41 +0000 (21:11 +0100)
commit 9ee8578d953023cc57e7e736ae48502c707c0210 upstream.

Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
kfree, iounmap, clk_put etc are not needed anymore in remove path.

Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
[ commit message spelling fix ]
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/arm/plat-pxa/ssp.c

index cde15e6ebad3c21ba65ba380b5e70bd75842ac01..2bd5b173294d8e475af37a4a85c54baf3ade02b3 100644 (file)
@@ -232,18 +232,12 @@ static int pxa_ssp_probe(struct platform_device *pdev)
 
 static int pxa_ssp_remove(struct platform_device *pdev)
 {
-       struct resource *res;
        struct ssp_device *ssp;
 
        ssp = platform_get_drvdata(pdev);
        if (ssp == NULL)
                return -ENODEV;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       release_mem_region(res->start, resource_size(res));
-
-       clk_put(ssp->clk);
-
        mutex_lock(&ssp_lock);
        list_del(&ssp->node);
        mutex_unlock(&ssp_lock);