Prevent sqlite from over-reading a structure

Our sqlite fork was reading past the end of the zP3 KeyInfo structure
here.  This was causing gcc and clang's address sanitization to alert.

FS-6279 --resolve

Thanks-to: Christopher Rienzo <chris@rienzo.net>

diff --git a/libs/sqlite/src/vdbeaux.c b/libs/sqlite/src/vdbeaux.c
index be85e7b8cb3ac0a73a9559484eb6a967100df8c8..11605e525aa0b1049bdfb2e234570d49289b2107 100644 (file)
--- a/libs/sqlite/src/vdbeaux.c
+++ b/libs/sqlite/src/vdbeaux.c
@@ -527,7 +527,7 @@ void sqlite3VdbeChangeP3(Vdbe *p, int addr, const char *zP3, int n){
     pOp->p3 = (char*)pKeyInfo;
     if( pKeyInfo ){
       unsigned char *aSortOrder;
-      memcpy(pKeyInfo, zP3, nByte);
+      memcpy(pKeyInfo, zP3, nByte - nField);
       aSortOrder = pKeyInfo->aSortOrder;
       if( aSortOrder ){
         pKeyInfo->aSortOrder = (unsigned char*)&pKeyInfo->aColl[nField];