]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Fix segfault in redis_ippool_tool stats
authorNick Porter <nick@portercomputing.co.uk>
Tue, 30 May 2023 11:23:25 +0000 (12:23 +0100)
committerNick Porter <nick@portercomputing.co.uk>
Tue, 30 May 2023 11:39:11 +0000 (12:39 +0100)
src/modules/rlm_redis_ippool/rlm_redis_ippool_tool.c

index 44cf27d5f17033c3f70d3d0b49296515b8665134..12b9ea48d857aafed13103503005b1ea72e061ba 100644 (file)
@@ -862,12 +862,12 @@ static ssize_t driver_get_pools(TALLOC_CTX *ctx, uint8_t **out[], void *instance
        /*
         *      Sort the results
         */
-       {
+       if (used > 1) {
                uint8_t const **to_sort;
 
                memcpy(&to_sort, &result, sizeof(to_sort));
 
-               fr_quick_sort((void const **)to_sort, 0, used, pool_cmp);
+               fr_quick_sort((void const **)to_sort, 0, used - 1, pool_cmp);
        }
 
        *out = talloc_array(ctx, uint8_t *, used);