codegen: Fix leak when casting from variant to another type

Fixes bug 656398.

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index e0011e7bdadab9240c9552b75013eb7927a5b2b6..2a2ee263910a3406d02dc650a06613e09524aeb4 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -4512,8 +4512,16 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
 
                string variant_func = "_variant_get%d".printf (++next_variant_function_id);
 
+               var variant = value;
+               if (value.value_type.value_owned) {
+                       // value leaked, destroy it
+                       var temp_value = store_temp_value (value, node);
+                       temp_ref_values.insert (0, ((GLibValue) temp_value).copy ());
+                       variant = temp_value;
+               }
+
                var ccall = new CCodeFunctionCall (new CCodeIdentifier (variant_func));
-               ccall.add_argument (get_cvalue_ (value));
+               ccall.add_argument (get_cvalue_ (variant));
 
                var result = create_temp_value (to, false, node);