upstream: adapt to EVP_PKEY conversion

OpenBSD-Regress-ID: 0e2d4efb0ed0e392e23cd8fda183fe56531ac446

diff --git a/regress/unittests/sshkey/common.c b/regress/unittests/sshkey/common.c
index 51b0d92e1d0734bd0ab7078b94a5e9d1422a162b..f325c2ac20257bf70e4f522b237c4c93fb7018c7 100644 (file)
--- a/regress/unittests/sshkey/common.c
+++ b/regress/unittests/sshkey/common.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: common.c,v 1.5 2021/12/14 21:25:27 deraadt Exp $ */
+/*     $OpenBSD: common.c,v 1.6 2024/08/15 00:52:23 djm Exp $ */
 /*
  * Helpers for key API tests
  *
@@ -89,8 +89,8 @@ rsa_n(struct sshkey *k)
        const BIGNUM *n = NULL;
 
        ASSERT_PTR_NE(k, NULL);
-       ASSERT_PTR_NE(k->rsa, NULL);
-       RSA_get0_key(k->rsa, &n, NULL, NULL);
+       ASSERT_PTR_NE(k->pkey, NULL);
+       RSA_get0_key(EVP_PKEY_get0_RSA(k->pkey), &n, NULL, NULL);
        return n;
 }
 
@@ -100,8 +100,8 @@ rsa_e(struct sshkey *k)
        const BIGNUM *e = NULL;
 
        ASSERT_PTR_NE(k, NULL);
-       ASSERT_PTR_NE(k->rsa, NULL);
-       RSA_get0_key(k->rsa, NULL, &e, NULL);
+       ASSERT_PTR_NE(k->pkey, NULL);
+       RSA_get0_key(EVP_PKEY_get0_RSA(k->pkey), NULL, &e, NULL);
        return e;
 }
 
@@ -111,8 +111,8 @@ rsa_p(struct sshkey *k)
        const BIGNUM *p = NULL;
 
        ASSERT_PTR_NE(k, NULL);
-       ASSERT_PTR_NE(k->rsa, NULL);
-       RSA_get0_factors(k->rsa, &p, NULL);
+       ASSERT_PTR_NE(EVP_PKEY_get0_RSA(k->pkey), NULL);
+       RSA_get0_factors(EVP_PKEY_get0_RSA(k->pkey), &p, NULL);
        return p;
 }
 
@@ -122,8 +122,8 @@ rsa_q(struct sshkey *k)
        const BIGNUM *q = NULL;
 
        ASSERT_PTR_NE(k, NULL);
-       ASSERT_PTR_NE(k->rsa, NULL);
-       RSA_get0_factors(k->rsa, NULL, &q);
+       ASSERT_PTR_NE(EVP_PKEY_get0_RSA(k->pkey), NULL);
+       RSA_get0_factors(EVP_PKEY_get0_RSA(k->pkey), NULL, &q);
        return q;
 }
 

diff --git a/regress/unittests/sshkey/test_file.c b/regress/unittests/sshkey/test_file.c
index 45284059657bf3cf6ecdeb944ce467c3083eb9bf..3babe604dcca659eae3077876c2e5bb0abfcba3e 100644 (file)
--- a/regress/unittests/sshkey/test_file.c
+++ b/regress/unittests/sshkey/test_file.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: test_file.c,v 1.11 2024/01/11 01:45:58 djm Exp $ */
+/*     $OpenBSD: test_file.c,v 1.12 2024/08/15 00:52:23 djm Exp $ */
 /*
  * Regress test for sshkey.h key management API
  *
@@ -271,11 +271,12 @@ sshkey_file_tests(void)
 #ifndef OPENSSL_IS_BORINGSSL /* lacks EC_POINT_point2bn() */
        a = load_bignum("ecdsa_1.param.priv");
        b = load_bignum("ecdsa_1.param.pub");
-       c = EC_POINT_point2bn(EC_KEY_get0_group(k1->ecdsa),
-           EC_KEY_get0_public_key(k1->ecdsa), POINT_CONVERSION_UNCOMPRESSED,
-           NULL, NULL);
+       c = EC_POINT_point2bn(EC_KEY_get0_group(EVP_PKEY_get0_EC_KEY(k1->pkey)),
+           EC_KEY_get0_public_key(EVP_PKEY_get0_EC_KEY(k1->pkey)),
+           POINT_CONVERSION_UNCOMPRESSED, NULL, NULL);
        ASSERT_PTR_NE(c, NULL);
-       ASSERT_BIGNUM_EQ(EC_KEY_get0_private_key(k1->ecdsa), a);
+       ASSERT_BIGNUM_EQ(
+           EC_KEY_get0_private_key(EVP_PKEY_get0_EC_KEY(k1->pkey)), a);
        ASSERT_BIGNUM_EQ(b, c);
        BN_free(a);
        BN_free(b);

diff --git a/regress/unittests/sshkey/test_sshkey.c b/regress/unittests/sshkey/test_sshkey.c
index c1cbb11282381cab8dffa037a476f0eecf871d0a..5bf4b65cc055f8002ae6b6e8ece85c18786bc21a 100644 (file)
--- a/regress/unittests/sshkey/test_sshkey.c
+++ b/regress/unittests/sshkey/test_sshkey.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: test_sshkey.c,v 1.24 2024/01/11 01:45:58 djm Exp $ */
+/*     $OpenBSD: test_sshkey.c,v 1.25 2024/08/15 00:52:23 djm Exp $ */
 /*
  * Regress test for sshkey.h key management API
  *
@@ -204,7 +204,7 @@ sshkey_tests(void)
        TEST_START("new/free KEY_RSA");
        k1 = sshkey_new(KEY_RSA);
        ASSERT_PTR_NE(k1, NULL);
-       ASSERT_PTR_NE(k1->rsa, NULL);
+       ASSERT_PTR_NE(k1->pkey, NULL);
        sshkey_free(k1);
        TEST_DONE();
 
@@ -221,7 +221,7 @@ sshkey_tests(void)
        TEST_START("new/free KEY_ECDSA");
        k1 = sshkey_new(KEY_ECDSA);
        ASSERT_PTR_NE(k1, NULL);
-       ASSERT_PTR_EQ(k1->ecdsa, NULL);  /* Can't allocate without NID */
+       ASSERT_PTR_EQ(k1->pkey, NULL);  /* Can't allocate without NID */
        sshkey_free(k1);
        TEST_DONE();
 #endif
@@ -270,7 +270,7 @@ sshkey_tests(void)
            SSH_ERR_KEY_LENGTH);
        ASSERT_INT_EQ(sshkey_generate(KEY_RSA, 1024, &kr), 0);
        ASSERT_PTR_NE(kr, NULL);
-       ASSERT_PTR_NE(kr->rsa, NULL);
+       ASSERT_PTR_NE(EVP_PKEY_get0_RSA(kr->pkey), NULL);
        ASSERT_PTR_NE(rsa_n(kr), NULL);
        ASSERT_PTR_NE(rsa_e(kr), NULL);
        ASSERT_PTR_NE(rsa_p(kr), NULL);
@@ -291,9 +291,11 @@ sshkey_tests(void)
        TEST_START("generate KEY_ECDSA");
        ASSERT_INT_EQ(sshkey_generate(KEY_ECDSA, 256, &ke), 0);
        ASSERT_PTR_NE(ke, NULL);
-       ASSERT_PTR_NE(ke->ecdsa, NULL);
-       ASSERT_PTR_NE(EC_KEY_get0_public_key(ke->ecdsa), NULL);
-       ASSERT_PTR_NE(EC_KEY_get0_private_key(ke->ecdsa), NULL);
+       ASSERT_PTR_NE(EVP_PKEY_get0_EC_KEY(ke->pkey), NULL);
+       ASSERT_PTR_NE(EC_KEY_get0_public_key(EVP_PKEY_get0_EC_KEY(ke->pkey)),
+           NULL);
+       ASSERT_PTR_NE(EC_KEY_get0_private_key(EVP_PKEY_get0_EC_KEY(ke->pkey)),
+           NULL);
        TEST_DONE();
 #endif /* OPENSSL_HAS_ECC */
 #endif /* WITH_OPENSSL */
@@ -312,7 +314,7 @@ sshkey_tests(void)
        ASSERT_PTR_NE(k1, NULL);
        ASSERT_PTR_NE(kr, k1);
        ASSERT_INT_EQ(k1->type, KEY_RSA);
-       ASSERT_PTR_NE(k1->rsa, NULL);
+       ASSERT_PTR_NE(EVP_PKEY_get0_RSA(k1->pkey), NULL);
        ASSERT_PTR_NE(rsa_n(k1), NULL);
        ASSERT_PTR_NE(rsa_e(k1), NULL);
        ASSERT_PTR_EQ(rsa_p(k1), NULL);
@@ -346,10 +348,12 @@ sshkey_tests(void)
        ASSERT_PTR_NE(k1, NULL);
        ASSERT_PTR_NE(ke, k1);
        ASSERT_INT_EQ(k1->type, KEY_ECDSA);
-       ASSERT_PTR_NE(k1->ecdsa, NULL);
+       ASSERT_PTR_NE(EVP_PKEY_get0_EC_KEY(k1->pkey), NULL);
        ASSERT_INT_EQ(k1->ecdsa_nid, ke->ecdsa_nid);
-       ASSERT_PTR_NE(EC_KEY_get0_public_key(ke->ecdsa), NULL);
-       ASSERT_PTR_EQ(EC_KEY_get0_private_key(k1->ecdsa), NULL);
+       ASSERT_PTR_NE(EC_KEY_get0_public_key(EVP_PKEY_get0_EC_KEY(ke->pkey)),
+          NULL);
+       ASSERT_PTR_EQ(EC_KEY_get0_private_key(EVP_PKEY_get0_EC_KEY(k1->pkey)),
+          NULL);
        TEST_DONE();
 
        TEST_START("equal KEY_ECDSA/demoted KEY_ECDSA");