]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: stream-int: don't needlessly call tasklet_wakeup() in stream_int_chk_snd_conn()
authorWilly Tarreau <w@1wt.eu>
Thu, 25 Oct 2018 11:49:49 +0000 (13:49 +0200)
committerWilly Tarreau <w@1wt.eu>
Sun, 28 Oct 2018 12:50:01 +0000 (13:50 +0100)
This one was added by commit 53216e7db ("MEDIUM: connections: Don't
directly mess with the polling from the upper layers.") after the
removal of the conditional cs_want_send() call. But after analysis
it turned out that it's not needed since the si_cs_send() call will
either succeed or subscribe.

src/stream_interface.c

index 4fd23c3a4d9fd6732b7319b4c9a329ef3cf1112f..e7ba722886ad3e0ea50ecb87a87cc2a591ffb999 100644 (file)
@@ -995,7 +995,7 @@ static void stream_int_chk_snd_conn(struct stream_interface *si)
 
        if (!(si->wait_event.wait_reason & SUB_CAN_SEND) && co_data(si_oc(si)))
                si_cs_send(cs);
-       tasklet_wakeup(si->wait_event.task);
+
        if (cs->flags & CS_FL_ERROR || cs->conn->flags & CO_FL_ERROR) {
                /* Write error on the file descriptor */
                si->flags |= SI_FL_ERR;