lib: glob: replace bitwise OR with logical operation on boolean

Using bitwise OR (|=) on a boolean variable is valid C, but replacing it
with a direct logical assignment makes the intent clearer and appeases
strict static analysis tools.

Link: https://lkml.kernel.org/r/20260301152143.2572137-2-objecting@objecting.org
Signed-off-by: Josh Law <objecting@objecting.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/lib/glob.c b/lib/glob.c
index 44a8d5e4e99b3e37d0dda58a39b224a0d17d02a9..877bdd0884a6163048a7962087cf4013b90a6439 100644 (file)
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -96,7 +96,8 @@ bool __pure glob_match(char const *pat, char const *str)
                                        class += 2;
                                        /* Any special action if a > b? */
                                }
-                               match |= (a <= c && c <= b);
+                               if (a <= c && c <= b)
+                                       match = true;
                        } while ((a = *class++) != ']');
 
                        if (match == inverted)