]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 8 May 2025 06:26:25 +0000 (09:26 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 14 May 2025 09:45:22 +0000 (17:45 +0800)
The pcim_iomap_region() returns error pointers.  It doesn't return NULL
pointers.  Update the check to match.

Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/qat/qat_6xxx/adf_drv.c

index 2531c337e0dd2d5827e281549bbb0990650320d7..132e26501621308187850b5c2e4f86343aad6dec 100644 (file)
@@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
                /* Map 64-bit PCIe BAR */
                bar->virt_addr = pcim_iomap_region(pdev, bar_map[i], pci_name(pdev));
-               if (!bar->virt_addr) {
-                       ret = -ENOMEM;
+               if (IS_ERR(bar->virt_addr)) {
+                       ret = PTR_ERR(bar->virt_addr);
                        return dev_err_probe(dev, ret, "Failed to ioremap PCI region.\n");
                }
        }