pinctrl: core: use dev_err_probe() when applying state

When applying a pinctrl state, -EPROBE_DEFER may be returned if
dependencies are not ready and the consumer will retry probing.

This is normal probe ordering behaviour and not a real error.
However, pinctrl core currently logs:

  "Error applying setting, reverse things back"

even when the return value is -EPROBE_DEFER, resulting in noisy
boot-time error messages.

Replace dev_err() with dev_err_probe() to handle -EPROBE_DEFER
consistently and suppress error logging for deferred probes.

No functional change intended.

Signed-off-by: Michal Piekos <michal.piekos@mmpsystems.pl>
Signed-off-by: Linus Walleij <linusw@kernel.org>

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index b5e97689589fbf1b6750620fc193bc820012be2b..2edc9bdad1832735cd9ca41e25eb2f8b4b5b4a1a 100644 (file)
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1350,7 +1350,8 @@ unapply_mux_setting:
        goto restore_old_state;
 
 unapply_new_state:
-       dev_err(p->dev, "Error applying setting, reverse things back\n");
+       dev_err_probe(p->dev, ret,
+                     "Error applying setting, reverse things back\n");
 
        /*
         * All we can do here is pinmux_disable_setting.