[trac3576] Updates per review comments

Typo level changes per review comments.

diff --git a/ChangeLog b/ChangeLog
index ff2947fd3a2cdd5639b4b71622bfc20bde183ee2..dd2546fc47972e09b778a0079696e03e8999c242 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+101x.   [func]         sar
+       Added support for several options for use by PXE.
+       From RFC4578 (for DHCPv4) these are: 93 - client-system,
+       94 - client-ndi, 97 - uuid-guid.
+       From RFC5970 (for  DHCPv6) these are: 59 - bootfile-url,
+       60 - bootfile-param, 61 - client-arch-type, 62 - nii.
+       (trac #3576, git <TBD>)
+
 1011.  [func]          fdupont
        Added definitions and tests for the options from secure DHCPv6.
        This protocol is still experimental. The option and other protocol

diff --git a/src/lib/dhcp/option_opaque_data_tuples.h b/src/lib/dhcp/option_opaque_data_tuples.h
index 9e656caa9060c47fb5874d22d7ee86414f845877..d9507c875b9ce3d1040677b4a1092d3b67682a73 100644 (file)
--- a/src/lib/dhcp/option_opaque_data_tuples.h
+++ b/src/lib/dhcp/option_opaque_data_tuples.h
@@ -107,9 +107,9 @@ public:
 
     /// @brief Returns opaque data tuple at the specified position.
     ///
-    ///  If the specified position is out of range an exception is thrown.
+    /// If the specified position is out of range an exception is thrown.
     ///
-    /// @param at Index at which the tuple should be replaced.
+    /// @param at Index for which tuple to get.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     OpaqueDataTuple getTuple(const size_t at) const;
 
@@ -123,7 +123,7 @@ public:
         return (tuples_);
     }
 
-    /// @brief Checks if the object  holds the opaque data tuple with the
+    /// @brief Checks if the object holds the opaque data tuple with the
     /// specified string.
     ///
     /// @param tuple_str String representation of the tuple being searched.

diff --git a/src/lib/dhcp/option_vendor_class.h b/src/lib/dhcp/option_vendor_class.h
index 83a3831bd6855c900f70824df577d02a39023875..51d410f75d5d71b57965e58140aab5bf651f6f17 100644 (file)
--- a/src/lib/dhcp/option_vendor_class.h
+++ b/src/lib/dhcp/option_vendor_class.h
@@ -119,9 +119,9 @@ public:
 
     /// @brief Returns opaque data tuple at the specified position.
     ///
-    ///  If the specified position is out of range an exception is thrown.
+    /// If the specified position is out of range an exception is thrown.
     ///
-    /// @param at Index at which the tuple should be replaced.
+    /// @param at Index for which tuple to get.
     /// @throw isc::OutOfRange if the tuple position is out of range.
     OpaqueDataTuple getTuple(const size_t at) const;
 

diff --git a/src/lib/dhcp/tests/libdhcp++_unittest.cc b/src/lib/dhcp/tests/libdhcp++_unittest.cc
index 1e5d6a854956b805085ca881e91fe4eb6cdd5263..fef4b5d092599c99e3b28c09a12861b4157af03e 100644 (file)
--- a/src/lib/dhcp/tests/libdhcp++_unittest.cc
+++ b/src/lib/dhcp/tests/libdhcp++_unittest.cc
@@ -1179,7 +1179,7 @@ TEST_F(LibDhcpTest, stdOptionDefs6) {
                                     typeid(Option6AddrLst));
 
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_URL, begin, end,
-                                   typeid(OptionString));
+                                    typeid(OptionString));
 
     LibDhcpTest::testStdOptionDefs6(D6O_BOOTFILE_PARAM, bparam_buf.begin(),
                                     bparam_buf.end(),

diff --git a/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc b/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc
index 7dbd905710114a0371fd3c3fdab7a68d0e6db2e6..fa3958071cb88e074f48881731456d8c7289bf25 100644 (file)
--- a/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc
+++ b/src/lib/dhcp/tests/option_opaque_data_tuples_unittest.cc
@@ -215,7 +215,7 @@ TEST(OptionOpaqueDataTuples, unpack6NoTuple) {
     // Prepare data to decode.
     const uint8_t buf_data[] = {
     };
-    OptionBuffer buf(buf_data,buf_data + sizeof(buf_data));
+    OptionBuffer buf(buf_data, buf_data + sizeof(buf_data));
 
     OptionOpaqueDataTuplesPtr data_tuple;
     ASSERT_NO_THROW(