sunrpc: removed redundant procp check

[ Upstream commit a576f36971ab4097b6aa76433532aa1fb5ee2d3b ]

since vs_proc pointer is dereferenced before getting it's address there's
no need to check for NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8e5b67731d08 ("SUNRPC: Add a callback to initialise server requests")
Signed-off-by: Aleksandr Aprelkov <aaprelkov@usergate.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 9177b243a949dd16d553169bbb478f2569f9bfa5..8d5897ed2816fd1db268bfde51f218b227469697 100644 (file)
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -1238,8 +1238,6 @@ svc_generic_init_request(struct svc_rqst *rqstp,
        if (rqstp->rq_proc >= versp->vs_nproc)
                goto err_bad_proc;
        rqstp->rq_procinfo = procp = &versp->vs_proc[rqstp->rq_proc];
-       if (!procp)
-               goto err_bad_proc;
 
        /* Initialize storage for argp and resp */
        memset(rqstp->rq_argp, 0, procp->pc_argzero);