]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: qcom: gcc-sm6350: Fix gpll6* & gpll7 parents
authorLuca Weiss <luca.weiss@fairphone.com>
Wed, 8 May 2024 08:12:53 +0000 (10:12 +0200)
committerBjorn Andersson <andersson@kernel.org>
Tue, 28 May 2024 21:30:23 +0000 (16:30 -0500)
Both gpll6 and gpll7 are parented to CXO at 19.2 MHz and not to GPLL0
which runs at 600 MHz. Also gpll6_out_even should have the parent gpll6
and not gpll0.

Adjust the parents of these clocks to make Linux report the correct rate
and not absurd numbers like gpll7 at ~25 GHz or gpll6 at 24 GHz.

Corrected rates are the following:

  gpll7              807999902 Hz
  gpll6              768000000 Hz
     gpll6_out_even  384000000 Hz
  gpll0              600000000 Hz
     gpll0_out_odd   200000000 Hz
     gpll0_out_even  300000000 Hz

And because gpll6 is the parent of gcc_sdcc2_apps_clk_src (at 202 MHz)
that clock also reports the correct rate now and avoids this warning:

  [    5.984062] mmc0: Card appears overclocked; req 202000000 Hz, actual 6312499237 Hz

Fixes: 131abae905df ("clk: qcom: Add SM6350 GCC driver")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Link: https://lore.kernel.org/r/20240508-sm6350-gpll-fix-v1-1-e4ea34284a6d@fairphone.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/gcc-sm6350.c

index cf4a7b6e0b23adfcca2c74aea74aa8e14ccfe20f..0559a33faf00e66f0703d74cae6b0af5a63d8b87 100644 (file)
@@ -100,8 +100,8 @@ static struct clk_alpha_pll gpll6 = {
                .enable_mask = BIT(6),
                .hw.init = &(struct clk_init_data){
                        .name = "gpll6",
-                       .parent_hws = (const struct clk_hw*[]){
-                               &gpll0.clkr.hw,
+                       .parent_data = &(const struct clk_parent_data){
+                               .fw_name = "bi_tcxo",
                        },
                        .num_parents = 1,
                        .ops = &clk_alpha_pll_fixed_fabia_ops,
@@ -124,7 +124,7 @@ static struct clk_alpha_pll_postdiv gpll6_out_even = {
        .clkr.hw.init = &(struct clk_init_data){
                .name = "gpll6_out_even",
                .parent_hws = (const struct clk_hw*[]){
-                       &gpll0.clkr.hw,
+                       &gpll6.clkr.hw,
                },
                .num_parents = 1,
                .ops = &clk_alpha_pll_postdiv_fabia_ops,
@@ -139,8 +139,8 @@ static struct clk_alpha_pll gpll7 = {
                .enable_mask = BIT(7),
                .hw.init = &(struct clk_init_data){
                        .name = "gpll7",
-                       .parent_hws = (const struct clk_hw*[]){
-                               &gpll0.clkr.hw,
+                       .parent_data = &(const struct clk_parent_data){
+                               .fw_name = "bi_tcxo",
                        },
                        .num_parents = 1,
                        .ops = &clk_alpha_pll_fixed_fabia_ops,