Bug 794125: Make User.get ignore duplicate groups for membership look ups

r=glob, a=LpSolit

diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm
index 5b54285c61ea7640bb7136bcf67f68b27dc15c49..d49ad24a0a4b5bfcf1753c548aa2750ff345f718 100644 (file)
--- a/Bugzilla/WebService/User.pm
+++ b/Bugzilla/WebService/User.pm
@@ -308,10 +308,12 @@ sub _filter_users_by_group {
                      @{ $group_ids || [] };
     my @name_groups = map { Bugzilla::Group->check($_) } 
                           @{ $group_names || [] };
-    push(@groups, @name_groups);
-    
+    my %unique_groups;
+    foreach my $group (@groups, @name_groups) {
+        $unique_groups{$group->id} ||= $group;
+    }
 
-    my @in_group = grep { $self->_user_in_any_group($_, \@groups) }
+    my @in_group = grep { $self->_user_in_any_group($_, [values %unique_groups]) }
                         @$users;
     return \@in_group;
 }