]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests/seccomp: Fix pointer type mismatch build error
authorKuan-Ying Lee <kuan-ying.lee@canonical.com>
Wed, 15 Jul 2026 05:35:52 +0000 (13:35 +0800)
committerKees Cook <kees@kernel.org>
Thu, 16 Jul 2026 01:11:29 +0000 (18:11 -0700)
We hit the following build error while running the seccomp selftests in
our testing.

CC seccomp_bpf
seccomp_bpf.c: In function ‘UPROBE_setup’:
seccomp_bpf.c:5175:74: error: pointer type mismatch in conditional expression [-Wincompatible-pointer-types]
5175 | offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe);
| ^
seccomp_bpf.c:5175:57: note: first expression has type ‘int (*)(void)’
5175 | offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe);
| ^~~~~~~~~~~~~~~~
seccomp_bpf.c:5175:76: note: second expression has type ‘int (__attribute__((nocf_check)) *)(void)’
5175 | offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe);
| ^~~~~~~~~~~~~

get_uprobe_offset() takes a 'const void *' argument, so cast both
operands to 'void *'.

Fixes: 9ffc7a635c35 ("selftests/seccomp: validate uprobe syscall passes through seccomp")
Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: https://patch.msgid.link/20260715053559.28535-1-kuan-ying.lee@canonical.com
Signed-off-by: Kees Cook <kees@kernel.org>
tools/testing/selftests/seccomp/seccomp_bpf.c

index 358b6c65e120e88ae9dbaef6a8359fcc4e977478..0622bc2acad40cf6d761db9fa60653be0acab2a0 100644 (file)
@@ -5178,7 +5178,8 @@ FIXTURE_SETUP(UPROBE)
                ASSERT_GE(bit, 0);
        }
 
-       offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : probed_uprobe);
+       offset = get_uprobe_offset(variant->uretprobe ? (void *)probed_uretprobe
+                                                     : (void *)probed_uprobe);
        ASSERT_GE(offset, 0);
 
        if (variant->uretprobe)