selftests: net: improve error handling in passive TFO test

Improve the error handling in passive TFO test to check the return value
from sendto(), and to fail if read() or fprintf() failed.

Signed-off-by: Yohei Kojima <yk@y-koj.net>
Link: https://patch.msgid.link/24707c8133f7095c0e5a94afa69e75c3a80bf6e7.1768312014.git.yk@y-koj.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/tools/testing/selftests/net/tfo.c b/tools/testing/selftests/net/tfo.c
index 8d82140f0f7679f7dd7fc522114418fb0e2d5f71..3b1ee2d3d41706c962f1e2b9d8c7043b6586531c 100644 (file)
--- a/tools/testing/selftests/net/tfo.c
+++ b/tools/testing/selftests/net/tfo.c
@@ -82,8 +82,10 @@ static void run_server(void)
                error(1, errno, "getsockopt(SO_INCOMING_NAPI_ID)");
 
        if (read(connfd, buf, 64) < 0)
-               perror("read()");
-       fprintf(outfile, "%d\n", opt);
+               error(1, errno, "read()");
+
+       if (fprintf(outfile, "%d\n", opt) < 0)
+               error(1, errno, "fprintf()");
 
        fclose(outfile);
        close(connfd);
@@ -92,14 +94,17 @@ static void run_server(void)
 
 static void run_client(void)
 {
-       int fd;
+       int fd, ret;
        char *msg = "Hello, world!";
 
        fd = socket(AF_INET6, SOCK_STREAM, 0);
        if (fd == -1)
                error(1, errno, "socket()");
 
-       sendto(fd, msg, strlen(msg), MSG_FASTOPEN, (struct sockaddr *)&cfg_addr, sizeof(cfg_addr));
+       ret = sendto(fd, msg, strlen(msg), MSG_FASTOPEN,
+                    (struct sockaddr *)&cfg_addr, sizeof(cfg_addr));
+       if (ret < 0)
+               error(1, errno, "sendto()");
 
        close(fd);
 }