BFD: Fix crash related to reconfiguration and passwords

Any change in BFD iface configuration should trigger session
reconfiguration, as config is copied into the bfd_session structure
and not just accessed through the bfd_iface structure.

As bfd_session now contains a pointer to the password list allocated
from the configuration, forgetting to update the bfd_session causes
use-after-free.

Thanks to Lexi Winter for the bugreport.

diff --git a/proto/bfd/bfd.c b/proto/bfd/bfd.c
index 4997f803ac6081c90442aa0f482ecd0ae2ae74e3..eba7a0ed5a1f2a636549c59887fa621b97bad5a2 100644 (file)
--- a/proto/bfd/bfd.c
+++ b/proto/bfd/bfd.c
@@ -589,6 +589,8 @@ bfd_reconfigure_sessions(struct deferred_call *dc)
          min_tx_int,
          idle_tx_int,
          multiplier,
+         auth_type,
+         passwords,
          passive) false; /* terminating the || chain */
 #undef CHK