Fix argment validation in krb5_make_fulladdr

Check kaddr and kport, not kport twice.

[ghudson@mit.edu: clarified commit message, minor style change]

diff --git a/src/lib/krb5/os/mk_faddr.c b/src/lib/krb5/os/mk_faddr.c
index 7e125cfcf7e73afac2cb9c5ec2cdaa332e6a6c94..2577df3010ae1dcfca91f18e8f1b14e7fd974ed8 100644 (file)
--- a/src/lib/krb5/os/mk_faddr.c
+++ b/src/lib/krb5/os/mk_faddr.c
@@ -42,7 +42,7 @@ krb5_make_fulladdr(krb5_context context, krb5_address *kaddr,
     krb5_int32 tmp32;
     krb5_int16 tmp16;
 
-    if ((kport == NULL) || (kport == NULL))
+    if (kaddr == NULL || kport == NULL)
         return EINVAL;
 
     raddr->length = kaddr->length + kport->length + (4 * sizeof(krb5_int32));