drm/amdgpu: avoid buffer overflow attach in smu_sys_set_pp_table()

commit 1abb2648698bf10783d2236a6b4a7ca5e8021699 upstream.

It malicious user provides a small pptable through sysfs and then
a bigger pptable, it may cause buffer overflow attack in function
smu_sys_set_pp_table().

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 1a02930d93df1e15db168173a004d480901f6ab9..537285f255ab9fe0fc8ab46431f61ef181c0568b 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -516,7 +516,8 @@ static int smu_sys_set_pp_table(void *handle,
                return -EIO;
        }
 
-       if (!smu_table->hardcode_pptable) {
+       if (!smu_table->hardcode_pptable || smu_table->power_play_table_size < size) {
+               kfree(smu_table->hardcode_pptable);
                smu_table->hardcode_pptable = kzalloc(size, GFP_KERNEL);
                if (!smu_table->hardcode_pptable)
                        return -ENOMEM;